Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure device supports CookieManager before using. #1815

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Make sure device supports CookieManager before using. #1815

merged 1 commit into from
Oct 21, 2021

Conversation

JBassett
Copy link
Collaborator

Summary

Fixes: #1812
Only add a cookieJar if the CookieManager actually works. Aka don't use it for wear.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

dshokouhi
dshokouhi approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will close #1814 in favor of this one

@dshokouhi dshokouhi mentioned this pull request Oct 21, 2021
Closed
@JBassett JBassett merged commit ca9706b into master Oct 21, 2021
@JBassett JBassett deleted the bugfix/wearOsCookieManager branch October 21, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshokouhi dshokouhi dshokouhi approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wear OS Crash On Launch
3 participants
@JBassett @dshokouhi @homeassistant